]> git.baikalelectronics.ru Git - kernel.git/commit
iommu/amd: Fix get_acpihid_device_id()
authorRaul E Rangel <rrangel@chromium.org>
Mon, 11 May 2020 16:33:36 +0000 (10:33 -0600)
committerJoerg Roedel <jroedel@suse.de>
Wed, 13 May 2020 09:14:41 +0000 (11:14 +0200)
commit16e52be2579d6e0d49db74a16e5d2365b0ab6e94
tree78717e5d9f562a88acef0ae311f308bd55f7102a
parent32f6e160cca762fd3e20ea06fc3af7561dad9e6b
iommu/amd: Fix get_acpihid_device_id()

acpi_dev_hid_uid_match() expects a null pointer for UID if it doesn't
exist. The acpihid_map_entry contains a char buffer for holding the
UID. If no UID was provided in the IVRS table, this buffer will be
zeroed. If we pass in a null string, acpi_dev_hid_uid_match() will
return false because it will try and match an empty string to the ACPI
UID of the device.

Fixes: deceed2ba829 ("iommu/amd: Switch to use acpi_dev_hid_uid_match()")
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20200511103229.v2.1.I6f1b6f973ee6c8af1348611370c73a0ec0ea53f1@changeid
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/amd_iommu.c