]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: qla2xxx: Fix missed DMA unmap for aborted commands
authorGleb Chesnokov <Chesnokov.G@raidix.com>
Fri, 15 Apr 2022 12:42:29 +0000 (12:42 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 3 May 2022 00:36:15 +0000 (20:36 -0400)
commit16b4bc7eb8fab62febf64eca5539110a87e89259
tree11c15d649de1049c87243d22df48179e53df584d
parent8e171aaa743662fcda80f482dc6d368b111d4f53
scsi: qla2xxx: Fix missed DMA unmap for aborted commands

Aborting commands that have already been sent to the firmware can
cause BUG in qlt_free_cmd(): BUG_ON(cmd->sg_mapped)

For instance:

 - Command passes rdx_to_xfer state, maps sgl, sends to the firmware

 - Reset occurs, qla2xxx performs ISP error recovery, aborts the command

 - Target stack calls qlt_abort_cmd() and then qlt_free_cmd()

 - BUG_ON(cmd->sg_mapped) in qlt_free_cmd() occurs because sgl was not
   unmapped

Thus, unmap sgl in qlt_abort_cmd() for commands with the aborted flag set.

Link: https://lore.kernel.org/r/AS8PR10MB4952D545F84B6B1DFD39EC1E9DEE9@AS8PR10MB4952.EURPRD10.PROD.OUTLOOK.COM
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Gleb Chesnokov <Chesnokov.G@raidix.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_target.c