]> git.baikalelectronics.ru Git - kernel.git/commit
sch_hhf: ensure quantum and hhf_non_hh_weight are non-zero
authorCong Wang <xiyou.wangcong@gmail.com>
Sun, 8 Sep 2019 20:40:51 +0000 (13:40 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 10 Sep 2019 17:31:00 +0000 (18:31 +0100)
commit16a3353b58e6b43bf218f8e326053ac5feff5bf8
tree86d68edb39cf667c360d0b198d00b14eb4214776
parent738e5770d038841ce930a12dcc4f822f4e7bfb47
sch_hhf: ensure quantum and hhf_non_hh_weight are non-zero

In case of TCA_HHF_NON_HH_WEIGHT or TCA_HHF_QUANTUM is zero,
it would make no progress inside the loop in hhf_dequeue() thus
kernel would get stuck.

Fix this by checking this corner case in hhf_change().

Fixes: b2c67599f843 ("net-qdisc-hhf: Heavy-Hitter Filter (HHF) qdisc")
Reported-by: syzbot+bc6297c11f19ee807dc2@syzkaller.appspotmail.com
Reported-by: syzbot+041483004a7f45f1f20a@syzkaller.appspotmail.com
Reported-by: syzbot+55be5f513bed37fc4367@syzkaller.appspotmail.com
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Cc: Terry Lam <vtlam@google.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_hhf.c