]> git.baikalelectronics.ru Git - kernel.git/commit
rtc: ds1685: actually spin forever in poweroff path
authorJosh Poimboeuf <jpoimboe@redhat.com>
Fri, 15 Apr 2016 14:21:10 +0000 (09:21 -0500)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Fri, 20 May 2016 10:33:51 +0000 (12:33 +0200)
commit16114ac66788ffe1d60ae1334801fbc198ac84c2
tree1ef6c0361cc58f39377a6c331743709ac7486447
parent0a2ca81e5f4cc7cf8b45eb90c6e3244af1422461
rtc: ds1685: actually spin forever in poweroff path

objtool reports the following warning:

  drivers/rtc/rtc-ds1685.o: warning: objtool: ds1685_rtc_poweroff() falls through to next function ds1685_rtc_work_queue()

Similar to commit c511a1a97298 ("rtc: ds1685: actually spin forever in
poweroff error path"), there's another unreachable() annotation which is
actually reachable, which we missed the first time.

Actually spin forever to be consistent with the comment and to make the
unreachable() annotation guaranteed to be unreachable.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-ds1685.c