]> git.baikalelectronics.ru Git - kernel.git/commit
perf/core: Fix perf_sched_count derailment
authorAlexander Shishkin <alexander.shishkin@linux.intel.com>
Wed, 2 Mar 2016 11:24:14 +0000 (13:24 +0200)
committerIngo Molnar <mingo@kernel.org>
Tue, 8 Mar 2016 11:18:31 +0000 (12:18 +0100)
commit1609f67d06c02f86ea852602eccd2fe6178d3ad8
tree0eed4ff4664a465d7a6d9bb81413c4d04ee9fd8c
parent657cdb6dc8fd2727bb23d11545101b2736735a9e
perf/core: Fix perf_sched_count derailment

The error path in perf_event_open() is such that asking for a sampling
event on a PMU that doesn't generate interrupts will end up in dropping
the perf_sched_count even though it hasn't been incremented for this
event yet.

Given a sufficient amount of these calls, we'll end up disabling
scheduler's jump label even though we'd still have active events in the
system, thereby facilitating the arrival of the infernal regions upon us.

I'm fixing this by moving account_event() inside perf_event_alloc().

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: <stable@vger.kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Cc: vince@deater.net
Link: http://lkml.kernel.org/r/1456917854-29427-1-git-send-email-alexander.shishkin@linux.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/events/core.c