]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: first set up shared ports, then non-shared ports
authorVladimir Oltean <vladimir.oltean@nxp.com>
Wed, 5 Jan 2022 23:11:16 +0000 (01:11 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Jan 2022 11:59:10 +0000 (11:59 +0000)
commit15d871b2db75845a03297a5f6cc8de62b7c6ad37
tree0cd9e2a25732a0391f0d7bfcc588f4357760e9c1
parentfa1f70579ec3f91f8b19a6194e0b2eff38729bac
net: dsa: first set up shared ports, then non-shared ports

After commit 811dbc1790a8 ("net: dsa: flush switchdev workqueue before
tearing down CPU/DSA ports"), the port setup and teardown procedure
became asymmetric.

The fact of the matter is that user ports need the shared ports to be up
before they can be used for CPU-initiated termination. And since we
register net devices for the user ports, those won't be functional until
we also call the setup for the shared (CPU, DSA) ports. But we may do
that later, depending on the port numbering scheme of the hardware we
are dealing with.

It just makes sense that all shared ports are brought up before any user
port is. I can't pinpoint any issue due to the current behavior, but
let's change it nonetheless, for consistency's sake.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/dsa2.c