]> git.baikalelectronics.ru Git - kernel.git/commit
pwm: sun4i: Remove erroneous else branch
authorThierry Reding <thierry.reding@gmail.com>
Wed, 16 Dec 2020 17:33:55 +0000 (18:33 +0100)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 17 Dec 2020 13:23:49 +0000 (14:23 +0100)
commit154f57c156ea2ba3a769d13b657d032597791a66
tree3222cd457d1e233e2a0c90db6ed2a2e6e10f9985
parentf1a1d9e7990712a3fe8084297f233a9a28f2cb59
pwm: sun4i: Remove erroneous else branch

Commit f16532b15e37 ("pwm: sun4i: Remove redundant needs_delay") changed
the logic of an else branch so that the PWM_EN and PWM_CLK_GATING bits
are now cleared if the PWM is to be disabled, whereas previously the
condition was always false, and hence the branch never got executed.

This code is reported causing backlight issues on boards based on the
Allwinner A20 SoC. Fix this by removing the else branch, which restores
the behaviour prior to the offending commit.

Note that the PWM_EN and PWM_CLK_GATING bits still get cleared later in
sun4i_pwm_apply() if the PWM is to be disabled.

Fixes: f16532b15e37 ("pwm: sun4i: Remove redundant needs_delay")
Reported-by: Taras Galchenko <tpgalchenko@gmail.com>
Suggested-by: Taras Galchenko <tpgalchenko@gmail.com>
Tested-by: Taras Galchenko <tpgalchenko@gmail.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-sun4i.c