]> git.baikalelectronics.ru Git - kernel.git/commit
sch_cake: Return __NET_XMIT_STOLEN when consuming enqueued skb
authorToke Høiland-Jørgensen <toke@toke.dk>
Wed, 31 Aug 2022 09:21:03 +0000 (11:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 15 Sep 2022 10:04:50 +0000 (12:04 +0200)
commit1534971ca1b5a4b7abb8e9d2cedb335e55f00bc7
treeb9c45a192fd3ac7ac57e749be5923a97237d0cef
parent59cbeaaaa353b5414d71a28487f75d53e390e3f5
sch_cake: Return __NET_XMIT_STOLEN when consuming enqueued skb

[ Upstream commit ab1b0cd7b2a8d0ca01e018df7992da63fd1f6745 ]

When the GSO splitting feature of sch_cake is enabled, GSO superpackets
will be broken up and the resulting segments enqueued in place of the
original skb. In this case, CAKE calls consume_skb() on the original skb,
but still returns NET_XMIT_SUCCESS. This can confuse parent qdiscs into
assuming the original skb still exists, when it really has been freed. Fix
this by adding the __NET_XMIT_STOLEN flag to the return value in this case.

Fixes: 78257d7d092a ("sch_cake: Conditionally split GSO segments")
Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
Reported-by: zdi-disclosures@trendmicro.com # ZDI-CAN-18231
Link: https://lore.kernel.org/r/20220831092103.442868-1-toke@toke.dk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sched/sch_cake.c