]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: seq: Don't break snd_use_lock_sync() loop by timeout
authorTakashi Iwai <tiwai@suse.de>
Sun, 9 Apr 2017 08:41:27 +0000 (10:41 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 13 Apr 2017 12:13:25 +0000 (14:13 +0200)
commit1408487384cdb7df147e89b45727a867a577e99f
tree62eb024027ea491fe0c040dc9f0f2d906b6e0643
parenta1f1075bbdaab6b34a624de7518c2aa7c0463fba
ALSA: seq: Don't break snd_use_lock_sync() loop by timeout

The snd_use_lock_sync() (thus its implementation
snd_use_lock_sync_helper()) has the 5 seconds timeout to break out of
the sync loop.  It was introduced from the beginning, just to be
"safer", in terms of avoiding the stupid bugs.

However, as Ben Hutchings suggested, this timeout rather introduces a
potential leak or use-after-free that was apparently fixed by the
commit f9c134344897 ("ALSA: seq: Fix race during FIFO resize"):
for example, snd_seq_fifo_event_in() -> snd_seq_event_dup() ->
copy_from_user() could block for a long time, and snd_use_lock_sync()
goes timeout and still leaves the cell at releasing the pool.

For fixing such a problem, we remove the break by the timeout while
still keeping the warning.

Suggested-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/seq_lock.c