]> git.baikalelectronics.ru Git - kernel.git/commit
iio: buffer: make sure O_NONBLOCK is respected
authorNuno Sá <nuno.sa@analog.com>
Thu, 16 Feb 2023 10:14:51 +0000 (11:14 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Apr 2023 14:55:27 +0000 (16:55 +0200)
commit136d516b7c1d09780195dab1e362a3d43fa7bce9
treee91a6b154f06bcae6456e372cbaf78b9f60d144f
parentd407c1dfe6130436d370a24e5fb26131cd5f0f84
iio: buffer: make sure O_NONBLOCK is respected

commit 3da1814184582ed0faf039275a3f02e6f69944ee upstream.

For output buffers, there's no guarantee that the buffer won't be full
in the first iteration of the loop in which case we would block
independently of userspace passing O_NONBLOCK or not. Fix it by always
checking the flag before going to sleep.

While at it (and as it's a bit related), refactored the loop so that the
stop condition is 'written != n', i.e, run the loop until all data has
been copied into the IIO buffers. This makes the code a bit simpler.

Fixes: 8a29c3a94e475 ("iio: Add output buffer support")
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20230216101452.591805-3-nuno.sa@analog.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/industrialio-buffer.c