]> git.baikalelectronics.ru Git - kernel.git/commit
net/mlx5: Delete impossible dev->state checks
authorLeon Romanovsky <leonro@nvidia.com>
Sun, 1 Aug 2021 08:37:57 +0000 (11:37 +0300)
committerSaeed Mahameed <saeedm@nvidia.com>
Wed, 11 Aug 2021 18:14:30 +0000 (11:14 -0700)
commit1354f18ce48ac8d783f7d9b0fd5a4f9569c37dce
treeea627c98841f8b57d9bdaaf7bb4ded75fc308655
parent3d73f24356fe5f519dc8a3c9f84781c1116c07ae
net/mlx5: Delete impossible dev->state checks

New mlx5_core device structure is allocated through devlink_alloc
with\ kzalloc and that ensures that all fields are equal to zero
and it includes ->state too.

That means that checks of that field in the mlx5_init_one() is
completely redundant, because that function is called only once
in the begging of mlx5_core_dev lifetime.

PCI:
 .probe()
  -> probe_one()
   -> mlx5_init_one()

The recovery flow can't run at that time or before it, because relevant
work initialized later in mlx5_init_once().

Such initialization flow ensures that dev->state can't be
MLX5_DEVICE_STATE_UNINITIALIZED at all, so remove such impossible
checks.

Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/health.c
drivers/net/ethernet/mellanox/mlx5/core/main.c
include/linux/mlx5/driver.h