]> git.baikalelectronics.ru Git - kernel.git/commit
media: siano: be sure to not override devpath size
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 23 Apr 2018 13:14:30 +0000 (09:14 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 4 May 2018 12:55:36 +0000 (08:55 -0400)
commit134df5ed726e831b9deca829344426bd46c07fbd
tree9d679b7fc48833f5c0852f110eb47d4467d315bc
parent7e54b13c3943a17030f9936ddb718c17775ef878
media: siano: be sure to not override devpath size

Right now, at siano driver, all places where devpath is
defined has sizeof(devpath) == 32. So, there's no practical
risc of going past devpath array anywhere.

Still, code changes might cause troubles. It also confuses
Coverity:
CID 139059 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW)
9. fixed_size_dest: You might overrun the 32-character
   fixed-size string entry->devpath by copying devpath
   without checking the length.
10. parameter_as_source: Note: This defect has an
    elevated risk because the source argument
    is a parameter of the current function.

So, explicitly limit strcmp() and strcpy() to ensure that the
devpath size (32) will be respected.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/common/siano/smscoreapi.c