]> git.baikalelectronics.ru Git - kernel.git/commit
tipc: use lock_sock() in tipc_sk_reinit()
authorCong Wang <xiyou.wangcong@gmail.com>
Mon, 10 Dec 2018 19:49:55 +0000 (11:49 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 14 Dec 2018 21:16:33 +0000 (13:16 -0800)
commit1314ae349a3ca35dd2aa1405db3adc77b40b283c
treeef79c96eb556365029d89323ab6b74b92495f12c
parent71a8202f896112f8eee4381dbcb750dfdef35485
tipc: use lock_sock() in tipc_sk_reinit()

lock_sock() must be used in process context to be race-free with
other lock_sock() callers, for example, tipc_release(). Otherwise
using the spinlock directly can't serialize a parallel tipc_release().

As it is blocking, we have to hold the sock refcnt before
rhashtable_walk_stop() and release it after rhashtable_walk_start().

Fixes: 2ec141da9221 ("tipc: convert tipc reference table to use generic rhashtable")
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Cc: Ying Xue <ying.xue@windriver.com>
Cc: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/socket.c