]> git.baikalelectronics.ru Git - kernel.git/commit
drivers core: Free dma_range_map when driver probe failed
authorMeng Li <Meng.Li@windriver.com>
Tue, 5 Jan 2021 07:09:27 +0000 (15:09 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Jan 2021 15:36:19 +0000 (16:36 +0100)
commit130420a6c3a3e6ad9cf4da9b04e850b0b4ff0866
tree57f3a9a8e44ea6386ecc6881a4648cab5263896c
parent7ef47eb101f0dca6dbe94b167f11a8b3cbd1be02
drivers core: Free dma_range_map when driver probe failed

There will be memory leak if driver probe failed. Trace as below:
  backtrace:
    [<000000002415258f>] kmemleak_alloc+0x3c/0x50
    [<00000000f447ebe4>] __kmalloc+0x208/0x530
    [<0000000048bc7b3a>] of_dma_get_range+0xe4/0x1b0
    [<0000000041e39065>] of_dma_configure_id+0x58/0x27c
    [<000000006356866a>] platform_dma_configure+0x2c/0x40
    ......
    [<000000000afcf9b5>] ret_from_fork+0x10/0x3c

This issue is introduced by commit 2dd30c1b50dd("dma-mapping:
introduce DMA range map, supplanting dma_pfn_offset "). It doesn't
free dma_range_map when driver probe failed and cause above
memory leak. So, add code to free it in error path.

Fixes: 2dd30c1b50dd ("dma-mapping: introduce DMA range map, supplanting dma_pfn_offset ")
Cc: stable@vger.kernel.org
Signed-off-by: Meng Li <Meng.Li@windriver.com>
Link: https://lore.kernel.org/r/20210105070927.14968-1-Meng.Li@windriver.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/dd.c