]> git.baikalelectronics.ru Git - kernel.git/commit
ibmvnic: don't spin in tasklet
authorSukadev Bhattiprolu <sukadev@linux.ibm.com>
Sat, 22 Jan 2022 02:59:20 +0000 (18:59 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 Jan 2022 12:05:03 +0000 (12:05 +0000)
commit12fe4087f909f566361addcf629b5f4ea16a3ba7
tree726ccdf02ce36ad1a629844187a2f213d6fb46dd
parent53de5cfc42978829ae1fccaa5f4503971999f3e1
ibmvnic: don't spin in tasklet

ibmvnic_tasklet() continuously spins waiting for responses to all
capability requests. It does this to avoid encountering an error
during initialization of the vnic. However if there is a bug in the
VIOS and we do not receive a response to one or more queries the
tasklet ends up spinning continuously leading to hard lock ups.

If we fail to receive a message from the VIOS it is reasonable to
timeout the login attempt rather than spin indefinitely in the tasklet.

Fixes: fac45866afae ("ibmvnic: Make CRQ interrupt tasklet wait for all capabilities crqs")
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Reviewed-by: Dany Madden <drt@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/ibmvnic.c