]> git.baikalelectronics.ru Git - kernel.git/commit
soundwire: cadence: only prepare attached devices on clock stop
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 23 Mar 2021 01:37:07 +0000 (09:37 +0800)
committerVinod Koul <vkoul@kernel.org>
Tue, 30 Mar 2021 09:06:11 +0000 (14:36 +0530)
commit12c0ceb4ff1b0fd72e0d26669e3c5827d2b2c5f3
tree90be9ee88617414a73bee8d844a80a60e17acba2
parentf736f190730210d91a97c143a05f1224ebb3c26b
soundwire: cadence: only prepare attached devices on clock stop

We sometimes see COMMAND_IGNORED responses during the clock stop
sequence. It turns out we already have information if devices are
present on a link, so we should only prepare those when they
are attached.

In addition, even when COMMAND_IGNORED are received, we should still
proceed with the clock stop. The device will not be prepared but
that's not a problem.

The only case where the clock stop will fail is if the Cadence IP
reports an error (including a timeout), or if the devices throw a
COMMAND_FAILED response.

BugLink: https://github.com/thesofproject/linux/issues/2621
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20210323013707.21455-1-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/cadence_master.c