]> git.baikalelectronics.ru Git - kernel.git/commit
netfilter: nfnetlink_hook: fix check for snprintf() overflow
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 19 Jun 2021 13:55:46 +0000 (16:55 +0300)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 21 Jun 2021 20:05:29 +0000 (22:05 +0200)
commit1255e75c6a0387ac3ba39a565fbc874b2bf6a5c6
tree472932825e271ae415eab1dec306a68f754031f3
parent1dd34f37cea30ea008473a7c00eeb50028a0e8d5
netfilter: nfnetlink_hook: fix check for snprintf() overflow

The kernel version of snprintf() can't return negatives.  The
"ret > (int)sizeof(sym)" check is off by one because and it should be
>=.  Finally, we need to set a negative error code.

Fixes: 4d45a1287f09 ("netfilter: add new hook nfnl subsystem")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nfnetlink_hook.c