]> git.baikalelectronics.ru Git - kernel.git/commit
usb: idmouse: fix an uninit-value in idmouse_open
authorDongliang Mu <mudongliangabcd@gmail.com>
Thu, 22 Sep 2022 13:48:44 +0000 (21:48 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 11:22:58 +0000 (13:22 +0200)
commit12368d46ab1499f1d985e0e0a4862a248949f04f
tree84e37d258f8e17dc9b86fd2ade0651f74ee6961b
parent735b8457549447ebc794e92ca634b0f0c9116e71
usb: idmouse: fix an uninit-value in idmouse_open

[ Upstream commit f682e9fd27a656e52cdd62364fd71fbbc2d56c0d ]

In idmouse_create_image, if any ftip_command fails, it will
go to the reset label. However, this leads to the data in
bulk_in_buffer[HEADER..IMGSIZE] uninitialized. And the check
for valid image incurs an uninitialized dereference.

Fix this by moving the check before reset label since this
check only be valid if the data after bulk_in_buffer[HEADER]
has concrete data.

Note that this is found by KMSAN, so only kernel compilation
is tested.

Reported-by: syzbot+79832d33eb89fb3cd092@syzkaller.appspotmail.com
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Link: https://lore.kernel.org/r/20220922134847.1101921-1-dzm91@hust.edu.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/misc/idmouse.c