]> git.baikalelectronics.ru Git - kernel.git/commit
virtio-net: set queues after driver_ok
authorJason Wang <jasowang@redhat.com>
Thu, 10 Aug 2023 03:12:56 +0000 (23:12 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Aug 2023 15:52:33 +0000 (17:52 +0200)
commit120a89c36d3d9fb8cfe6bcfa97a2347bb3ba1178
tree8f55d1e35f206f9d4de004c5b17540b888ba4442
parent45085ba966fb10e167dab8c229651b5ecee48b66
virtio-net: set queues after driver_ok

[ Upstream commit 51b813176f098ff61bd2833f627f5319ead098a5 ]

Commit 25266128fe16 ("virtio-net: fix race between set queues and
probe") tries to fix the race between set queues and probe by calling
_virtnet_set_queues() before DRIVER_OK is set. This violates virtio
spec. Fixing this by setting queues after virtio_device_ready().

Note that rtnl needs to be held for userspace requests to change the
number of queues. So we are serialized in this way.

Fixes: 25266128fe16 ("virtio-net: fix race between set queues and probe")
Reported-by: Dragos Tatulea <dtatulea@nvidia.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/virtio_net.c