]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: WARN_ON fence pin leaks
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 13 May 2014 10:11:26 +0000 (12:11 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 13 May 2014 15:16:12 +0000 (17:16 +0200)
commit11daca0c2033fec4b009d43eec0e2b412e613ff4
treec7826b202d502f5b5b17637c6c0386f9bae2a72a
parent3fb7efcd65d6ace4deb10799411920c049fea8b7
drm/i915: WARN_ON fence pin leaks

The fence pin count should always be <= the bo pin count. If that's
not the case then we have a funny problem and are leaking references
somewhere.

Which means we can catch fence pin leaks by checking for the same
upper limit as we do for the bo pin count. Inspired by a discussion
with Ville about a fence leak igt testcase.

v2: Also check for fence->pin_count <= ggtt_vma->pin_count, since that
might catch a leak even quicker. Also de-inline them, they're getting
too big.

v3: Don't separately check for MAX_PIN_COUNT since the > vma->pin_count
check will catch that already (Chris).

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_drv.h
drivers/gpu/drm/i915/i915_gem.c