]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: firewire-lib/bebob/oxfw: improve response evaluation for AV/C commands
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Mon, 3 Apr 2017 12:13:55 +0000 (21:13 +0900)
committerTakashi Iwai <tiwai@suse.de>
Wed, 5 Apr 2017 19:37:23 +0000 (21:37 +0200)
commit11c9b2f1c5e7bfcd5304f1d7489b8a54eb4af345
tree244737dfe7058e9e958aee74358526c2656d5106
parent369e18332068403d745b366ec485d2cf97c313ef
ALSA: firewire-lib/bebob/oxfw: improve response evaluation for AV/C commands

In ALSA firewire stack, some AV/C commands are supported, including
vendor's extensions. Drivers includes response parser of each command,
according to its requirements, while the parser is written with loose
fashion in two points; error check and length check. This doesn't cause
any issues such as kernel corruption, but should be improved.

This commit modifies evaluations of return value on each parsers.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/bebob/bebob_command.c
sound/firewire/fcp.c
sound/firewire/oxfw/oxfw-command.c