]> git.baikalelectronics.ru Git - kernel.git/commit
net: qlcnic: add missed unlock in qlcnic_83xx_flash_read32
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Mon, 16 Aug 2021 13:14:04 +0000 (21:14 +0800)
committerSasha Levin <sashal@kernel.org>
Thu, 26 Aug 2021 12:36:18 +0000 (08:36 -0400)
commit119cefe64c0ac11293cb3243621fd66908b30d93
treee27155c5b8c60447b9396331b514a780a516c81e
parent989b43b17f43d2f70741f793edf15cb409b78758
net: qlcnic: add missed unlock in qlcnic_83xx_flash_read32

[ Upstream commit 0a298d133893c72c96e2156ed7cb0f0c4a306a3e ]

qlcnic_83xx_unlock_flash() is called on all paths after we call
qlcnic_83xx_lock_flash(), except for one error path on failure
of QLCRD32(), which may cause a deadlock. This bug is suggested
by a static analysis tool, please advise.

Fixes: ccc933513b4e0 ("qlcnic: flash template based firmware reset recovery")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20210816131405.24024-1-dinghao.liu@zju.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c