]> git.baikalelectronics.ru Git - kernel.git/commit
staging: vchiq: Fix bulk userdata handling
authorPhil Elwell <phil@raspberrypi.com>
Tue, 5 Jan 2021 16:20:28 +0000 (16:20 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 7 Jan 2021 15:56:43 +0000 (16:56 +0100)
commit117ccec466bd4a06a206a73b891fe17ab527863a
treed9e3078882b54aed033b2df8031db2363fcbb74a
parent21a336518a790788f877e2f1b108a1e03315a683
staging: vchiq: Fix bulk userdata handling

The addition of the local 'userdata' pointer to
vchiq_irq_queue_bulk_tx_rx omitted the case where neither BLOCKING nor
WAITING modes are used, in which case the value provided by the
caller is not returned to them as expected, but instead it is replaced
with a NULL. This lack of a suitable context may cause the application
to crash or otherwise malfunction.

Fixes: e3e1d119147c ("staging: vchiq: fix __user annotations")
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Link: https://lore.kernel.org/r/20210105162030.1415213-2-phil@raspberrypi.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c