]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/display: Fix HPD short pulse handling for eDP
authorJosé Roberto de Souza <jose.souza@intel.com>
Fri, 11 Mar 2022 18:51:48 +0000 (10:51 -0800)
committerJosé Roberto de Souza <jose.souza@intel.com>
Tue, 15 Mar 2022 15:41:29 +0000 (08:41 -0700)
commit1148a479a9dacac9c65002f84461c005b4e66703
treee058eda434e98e02ec2b1ea052ef32f073df7c94
parenta8aaa13defd6db236dbff6777be30a853a00ac66
drm/i915/display: Fix HPD short pulse handling for eDP

Commit 6b922f735843 ("drm/i915/edp: Ignore short pulse when panel
powered off") completely broke short pulse handling for eDP as it is
usually generated by sink when it is displaying image and there is
some error or status that source needs to handle.

When power panel is enabled, this state is enough to power aux
transactions and VDD override is disabled, so intel_pps_have_power()
is always returning false causing short pulses to be ignored.

So here better naming this function that intends to check if aux
lines are powered to avoid the endless cycle mentioned in the commit
being fixed and fixing the check for what it is intended.

v2:
- renamed to intel_pps_have_panel_power_or_vdd()
- fixed indentation

Fixes: 6b922f735843 ("drm/i915/edp: Ignore short pulse when panel powered off")
Cc: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220311185149.110527-1-jose.souza@intel.com
drivers/gpu/drm/i915/display/intel_dp.c
drivers/gpu/drm/i915/display/intel_pps.c
drivers/gpu/drm/i915/display/intel_pps.h