]> git.baikalelectronics.ru Git - kernel.git/commit
sit: proper dev_{hold|put} in ndo_[un]init methods
authorEric Dumazet <edumazet@google.com>
Mon, 29 Mar 2021 19:25:22 +0000 (12:25 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 29 Mar 2021 23:31:51 +0000 (16:31 -0700)
commit103869966b880bb7ad91c3b343b95321336156a9
tree2b7c7464b157ec0f70f96daa5e4f1320ff540561
parent35dc0581fcc48c459c1fb9b94960a83bb537ed4e
sit: proper dev_{hold|put} in ndo_[un]init methods

After adopting CONFIG_PCPU_DEV_REFCNT=n option, syzbot was able to trigger
a warning [1]

Issue here is that:

- all dev_put() should be paired with a corresponding prior dev_hold().

- A driver doing a dev_put() in its ndo_uninit() MUST also
  do a dev_hold() in its ndo_init(), only when ndo_init()
  is returning 0.

Otherwise, register_netdevice() would call ndo_uninit()
in its error path and release a refcount too soon.

Fixes: 8b4caa3fb199 ("net: add CONFIG_PCPU_DEV_REFCNT")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/sit.c