]> git.baikalelectronics.ru Git - kernel.git/commit
rtc: m41t80: Initialize clientdata before registering device
authorJohn Stultz <john.stultz@linaro.org>
Sat, 7 May 2011 00:24:27 +0000 (17:24 -0700)
committerJohn Stultz <john.stultz@linaro.org>
Sat, 7 May 2011 01:01:02 +0000 (18:01 -0700)
commit102e3446d5a2dd34daa0cb9e7b6d008b940c8575
tree38ad9e7bbb8b37e352d1810a4b48167838615504
parented3195cdea887d18162b26cc88bd0d94e78886cc
rtc: m41t80: Initialize clientdata before registering device

Commit 7a6b0e5dea5 ("RTC: Initialize kernel state from RTC") uncovered
an issue in a number of RTC drivers, where the drivers call
rtc_device_register before initializing the clientdata.

This frequently results in null pointer dereferences when the
rtc_device_register immediately makes use of the rtc device, calling
rtc_read_alarm.

The solution is to ensure the clientdata is initialized prior to registering
the rtc device.

CC: Wolfram Sang <w.sang@pengutronix.de>
CC: Alessandro Zummo <a.zummo@towertech.it>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: rtc-linux@googlegroups.com
Signed-off-by: John Stultz <john.stultz@linaro.org>
drivers/rtc/rtc-m41t80.c