]> git.baikalelectronics.ru Git - kernel.git/commit
netfilter: nf_tables: fix nft_counters_enabled underflow at nf_tables_addchain()
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Mon, 12 Sep 2022 12:41:00 +0000 (21:41 +0900)
committerFlorian Westphal <fw@strlen.de>
Tue, 20 Sep 2022 21:50:03 +0000 (23:50 +0200)
commit0f9a6986f255f8b0dac6ff13fcf75712f980fd3e
tree3a38cd3126b1d9bcbbdddfda8a1b668347d2d59b
parent7a248676e17cb2cc83c85944ff393814da5ef98f
netfilter: nf_tables: fix nft_counters_enabled underflow at nf_tables_addchain()

syzbot is reporting underflow of nft_counters_enabled counter at
nf_tables_addchain() [1], for commit eeaac9f662946216 ("netfilter:
nf_tables: do not leave chain stats enabled on error") missed that
nf_tables_chain_destroy() after nft_basechain_init() in the error path of
nf_tables_addchain() decrements the counter because nft_basechain_init()
makes nft_is_base_chain() return true by setting NFT_CHAIN_BASE flag.

Increment the counter immediately after returning from
nft_basechain_init().

Link:  https://syzkaller.appspot.com/bug?extid=b5d82a651b71cd8a75ab [1]
Reported-by: syzbot <syzbot+b5d82a651b71cd8a75ab@syzkaller.appspotmail.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Tested-by: syzbot <syzbot+b5d82a651b71cd8a75ab@syzkaller.appspotmail.com>
Fixes: eeaac9f662946216 ("netfilter: nf_tables: do not leave chain stats enabled on error")
Signed-off-by: Florian Westphal <fw@strlen.de>
net/netfilter/nf_tables_api.c