]> git.baikalelectronics.ru Git - kernel.git/commit
nbd: fix possible overflow on 'first_minor' in nbd_dev_add()
authorZhang Wensheng <zhangwensheng5@huawei.com>
Sat, 21 May 2022 07:37:48 +0000 (15:37 +0800)
committerJens Axboe <axboe@kernel.dk>
Sat, 28 May 2022 02:39:33 +0000 (20:39 -0600)
commit0f86780cfb00fe24fb0b01d6577bbddea3a48798
treed085e4f3e4577942f7aa6d9f823a0a8567fad6c0
parentfc1ba34274179cb8427a4ed28a79b1ae2dda3d53
nbd: fix possible overflow on 'first_minor' in nbd_dev_add()

When 'index' is a big numbers, it may become negative which forced
to 'int'. then 'index << part_shift' might overflow to a positive
value that is not greater than '0xfffff', then sysfs might complains
about duplicate creation. Because of this, move the 'index' judgment
to the front will fix it and be better.

Fixes: 9fca2a71b23a ("nbd: use an idr to keep track of nbd devices")
Fixes: 474bb5ed2ceb ("nbd: fix possible overflow for 'first_minor' in nbd_dev_add()")
Signed-off-by: Zhang Wensheng <zhangwensheng5@huawei.com>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Link: https://lore.kernel.org/r/20220521073749.3146892-6-yukuai3@huawei.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/nbd.c