]> git.baikalelectronics.ru Git - kernel.git/commit
PCI: microchip: Fix refcount leak in mc_pcie_init_irq_domains()
authorMiaoqian Lin <linmq006@gmail.com>
Sun, 5 Jun 2022 05:51:23 +0000 (09:51 +0400)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 8 Jun 2022 20:26:24 +0000 (15:26 -0500)
commit0f2b6296c7e653ad4081ec13a53c53e2fa6f49c9
treebd2822b77ea6c78940291ef26acd402218447fbd
parentcf1710d1388cf5bd81996b258399c4907d27006e
PCI: microchip: Fix refcount leak in mc_pcie_init_irq_domains()

of_get_next_child() returns a node pointer with refcount incremented, so we
should use of_node_put() on it when we don't need it anymore.

mc_pcie_init_irq_domains() only calls of_node_put() in the normal path,
missing it in some error paths.  Add missing of_node_put() to avoid
refcount leak.

Fixes: b3601c8a731d ("PCI: microchip: Add Microchip PolarFire PCIe controller driver")
Link: https://lore.kernel.org/r/20220605055123.59127-1-linmq006@gmail.com
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Rob Herring <robh@kernel.org>
drivers/pci/controller/pcie-microchip-host.c