]> git.baikalelectronics.ru Git - kernel.git/commit
ipvs: do not use random local source address for tunnels
authorJulian Anastasov <ja@ssi.bg>
Sat, 27 Jun 2015 11:39:30 +0000 (14:39 +0300)
committerSimon Horman <horms@verge.net.au>
Tue, 14 Jul 2015 07:41:27 +0000 (16:41 +0900)
commit0ef58dfbb5754b9b8e4ea61d696143c524b05198
treeb26da24dccaaa7d2a30c40cb06290efcc1cada26
parent968966917bd8e5e6a8c9e6a6ccf223461b032cba
ipvs: do not use random local source address for tunnels

Michael Vallaly reports about wrong source address used
in rare cases for tunneled traffic. Looks like
__ip_vs_get_out_rt in 3.10+ is providing uninitialized
dest_dst->dst_saddr.ip because ip_vs_dest_dst_alloc uses
kmalloc. While we retry after seeing EINVAL from routing
for data that does not look like valid local address, it
still succeeded when this memory was previously used from
other dests and with different local addresses. As result,
we can use valid local address that is not suitable for
our real server.

Fix it by providing 0.0.0.0 every time our cache is refreshed.
By this way we will get preferred source address from routing.

Reported-by: Michael Vallaly <lvs@nolatency.com>
Fixes: e983c06fc0a3 ("ipvs: optimize dst usage for real server")
Signed-off-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>
net/netfilter/ipvs/ip_vs_xmit.c