]> git.baikalelectronics.ru Git - kernel.git/commit
can: hi311x: fix a signedness bug in hi3110_cmd()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 29 Jul 2021 14:12:46 +0000 (17:12 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Aug 2021 10:27:40 +0000 (12:27 +0200)
commit0ecf6768a05a7ece21c248a7b3569ab872b73730
tree2e5c7f1a0a65745f46ab821c1432c185c80d5387
parent859a158fd5bf919c48d1d913b7c69e0e1aab1d40
can: hi311x: fix a signedness bug in hi3110_cmd()

[ Upstream commit f6b3c7848e66e9046c8a79a5b88fd03461cc252b ]

The hi3110_cmd() is supposed to return zero on success and negative
error codes on failure, but it was accidentally declared as a u8 when
it needs to be an int type.

Fixes: efc1b07ab6e7 ("can: hi311x: Add Holt HI-311x CAN driver")
Link: https://lore.kernel.org/r/20210729141246.GA1267@kili
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/can/spi/hi311x.c