]> git.baikalelectronics.ru Git - kernel.git/commit
wifi: p54: Fix an error handling path in p54spi_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 12 Jun 2022 21:12:20 +0000 (23:12 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:23:31 +0000 (14:23 +0200)
commit0e8a3d8b115c6795f8a2ad808558e8188a1475cd
tree51181aa1a547dc588e0639ab608b714af70b7713
parent035ff97bf59fd57c12f6dd13e49fd8727f0ea363
wifi: p54: Fix an error handling path in p54spi_probe()

[ Upstream commit 98514c653855a0265c18b1341829def59ead2915 ]

If an error occurs after a successful call to p54spi_request_firmware(), it
must be undone by a corresponding release_firmware() as already done in
the error handling path of p54spi_request_firmware() and in the .remove()
function.

Add the missing call in the error handling path and remove it from
p54spi_request_firmware() now that it is the responsibility of the caller
to release the firmware

Fixes: 2c22b07710f2 ("p54spi: p54spi driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Christian Lamparter <chunkeey@gmail.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/297d2547ff2ee627731662abceeab9dbdaf23231.1655068321.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/intersil/p54/p54spi.c