]> git.baikalelectronics.ru Git - kernel.git/commit
staging/speakup: Use tty_ldisc_ref() for paste kworker
authorPeter Hurley <peter@hurleysoftware.com>
Mon, 11 Jan 2016 06:40:58 +0000 (22:40 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Jan 2016 07:17:54 +0000 (23:17 -0800)
commit0e691dab88accbd87b5aea91673a29afd581b685
tree6cf6e1b2eff3ed51f0320bf9971eb27af8bf6e26
parente96ff33d3c5b5b5be0397026b792db0e2f61ad6e
staging/speakup: Use tty_ldisc_ref() for paste kworker

As the function documentation for tty_ldisc_ref_wait() notes, it is
only callable from a tty file_operations routine; otherwise there
is no guarantee the ref won't be NULL.

The key difference with the VT's paste_selection() is that is an ioctl,
where __speakup_paste_selection() is completely async kworker, kicked
off from interrupt context.

Fixes: 578d25a416b2 ("Staging: speakup: Update __speakup_paste_selection()
       tty (ab)usage to match vt")
Cc: <stable@vger.kernel.org>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/speakup/selection.c