]> git.baikalelectronics.ru Git - kernel.git/commit
staging: comedi: ni_mio_common: use insn->n in ni_calib_insn_read()
authorIan Abbott <abbotti@mev.co.uk>
Tue, 19 Mar 2019 16:54:42 +0000 (16:54 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Mar 2019 07:25:17 +0000 (08:25 +0100)
commit0e584bf65a7a346e0c3275685dcc4aeff5d8838b
treeda16466184040d56f41ce3cfc4d3c29a9a527412
parent0d5b8261d04915e577470b817a5a6efe187806c4
staging: comedi: ni_mio_common: use insn->n in ni_calib_insn_read()

The `insn_read` handler for the calibration subdevice
(`ni_calib_insn_read()`) currently ignores `insn->n` (the number of
samples to read) and assumes a single sample is to be read into
`data[0]`.  Fortunately, the Comedi core ensures that `data[]` has a
length of at least 16, so there is no problem with array bounds.

The usual Comedi convention for `insn_read` handlers is to read the same
channel `insn->n` times into successive elements of `data[]`, so let's
do that.

Also, follow the usual Comedi convention and return `insn->n` from the
handler to indicate success (although any non-negative value will do).

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/ni_mio_common.c