]> git.baikalelectronics.ru Git - kernel.git/commit
cxgb4: fix missing unlock on ETHOFLD desc collect fail path
authorRafael Mendonca <rafaelmendsr@gmail.com>
Thu, 22 Sep 2022 17:51:08 +0000 (14:51 -0300)
committerJakub Kicinski <kuba@kernel.org>
Mon, 26 Sep 2022 20:17:53 +0000 (13:17 -0700)
commit0e3374aa9f4ee47865cead4e124f968d66fbb6eb
tree4df3f44d53e6e48622658155e07fc2391c50fc16
parent0a1ee21d7b9f0b36100fcf801c3442833fb5c7bc
cxgb4: fix missing unlock on ETHOFLD desc collect fail path

The label passed to the QDESC_GET for the ETHOFLD TXQ, RXQ, and FLQ, is the
'out' one, which skips the 'out_unlock' label, and thus doesn't unlock the
'uld_mutex' before returning. Additionally, since commit 4525a89543d4
("cxgb4: add EOTID tracking and software context dump"), the access to
these ETHOFLD hardware queues should be protected by the 'mqprio_mutex'
instead.

Fixes: 62b24e7b11c6 ("cxgb4: add ETHOFLD hardware queue support")
Fixes: 4525a89543d4 ("cxgb4: add EOTID tracking and software context dump")
Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
Reviewed-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Link: https://lore.kernel.org/r/20220922175109.764898-1-rafaelmendsr@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c