]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/gem: Delay tracking the GEM context until it is registered
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 30 Jul 2020 09:28:56 +0000 (10:28 +0100)
committerJani Nikula <jani.nikula@intel.com>
Wed, 16 Sep 2020 08:09:20 +0000 (11:09 +0300)
commit0d863e7aa3e95add02ac01c5e9d9f4852d466bba
tree8ccaeafbcdfdb3ab1729bfc7a553a4c0181efd11
parent490b1f9d3b599ea255de59eeb320d58c1220e31c
drm/i915/gem: Delay tracking the GEM context until it is registered

Avoid exposing a partially constructed context by deferring the
list_add() from the initial construction to the end of registration.
Otherwise, if we peek into the list of contexts from inside debugfs, we
may see the partially constructed context and chase down some dangling
incomplete pointers.

Reported-by: CQ Tang <cq.tang@intel.com>
Fixes: ee45cd25f255 ("drm/i915: Separate GEM context construction and registration to userspace")
References: 8130320523a4 ("drm/i915: Report the number of closed vma held by each context in debugfs")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: CQ Tang <cq.tang@intel.com>
Cc: <stable@vger.kernel.org> # v5.2+
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200730092856.23615-1-chris@chris-wilson.co.uk
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
(cherry picked from commit eb4dedae920a07c485328af3da2202ec5184fb17)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/gem/i915_gem_context.c