]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "scsi: ufs: fix a missing check of devm_reset_control_get"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:56:57 +0000 (13:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 15:33:39 +0000 (17:33 +0200)
commit0d5ed0be540c2c9ef63ac94844462b623b22a33b
treee5dcd155022357a9beeb1487c0e88362f24c4d59
parent5076f0de6cdbe8e8c2cdd56a5bfdefdd93e42963
Revert "scsi: ufs: fix a missing check of devm_reset_control_get"

This reverts commit 97c71b04412128c9d35528af0cdf0d0982438aa4.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

The original commit is incorrect, it does not properly clean up on the
error path, so I'll keep the revert and fix it up properly with a
follow-on patch.

Cc: Kangjie Lu <kjlu@umn.edu>
Cc: Avri Altman <avri.altman@wdc.com>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Fixes: 97c71b044121 ("scsi: ufs: fix a missing check of devm_reset_control_get")
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210503115736.2104747-31-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/ufs/ufs-hisi.c