]> git.baikalelectronics.ru Git - kernel.git/commit
net: bridge: don't cache ether dest pointer on input
authorNikolay Aleksandrov <nikolay@cumulusnetworks.com>
Tue, 2 Jul 2019 12:00:20 +0000 (15:00 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 2 Jul 2019 18:53:03 +0000 (11:53 -0700)
commit0cb6c5c5e2f7300bb38105dc83e955ba29a0acd3
treef3b35856d12d170744c54dd5a056b23a74218043
parentb55d2ea64fd249d9a2660a140648d0c7aff9490a
net: bridge: don't cache ether dest pointer on input

We would cache ether dst pointer on input in br_handle_frame_finish but
after the neigh suppress code that could lead to a stale pointer since
both ipv4 and ipv6 suppress code do pskb_may_pull. This means we have to
always reload it after the suppress code so there's no point in having
it cached just retrieve it directly.

Fixes: a716f4a25563d ("bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports")
Fixes: 058bb1acc6dc ("bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports")
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_input.c