]> git.baikalelectronics.ru Git - kernel.git/commit
mptcp: fix 'masking a bool' warning
authorMatthieu Baerts <matthieu.baerts@tessares.net>
Fri, 25 Jun 2021 21:25:22 +0000 (14:25 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Jun 2021 20:04:06 +0000 (13:04 -0700)
commit0c89ac4fa7f9538fe43eff31affe9d42adfba44c
tree40a9dcb2b65b79b400e2c01e536a55ed86f04804
parent3a6aba302664e569280ef2b568d5dd4df8046c72
mptcp: fix 'masking a bool' warning

Dan Carpenter reported an issue introduced in
commit 4f5d850fc52e ("mptcp: refine mptcp_cleanup_rbuf") where a new
boolean (ack_pending) is masked with 0x9.

This is not the intention to ignore values by using a boolean. This
variable should not have a 'bool' type: we should keep the 'u8' to allow
this comparison.

Fixes: 4f5d850fc52e ("mptcp: refine mptcp_cleanup_rbuf")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mptcp/protocol.c