]> git.baikalelectronics.ru Git - kernel.git/commit
IB/cm: Replace members of sa_path_rec with 'struct sgid_attr *'
authorParav Pandit <parav@mellanox.com>
Tue, 19 Jun 2018 07:59:19 +0000 (10:59 +0300)
committerJason Gunthorpe <jgg@mellanox.com>
Mon, 25 Jun 2018 20:19:57 +0000 (14:19 -0600)
commit0c8921ba5f7f3b216b34f7d6e216c5d13d5e33d9
treeb1c2999fe1c4c537f9082ff5037a09edb3e8accf
parent947f3a37a594113487d6c487916d48add699455d
IB/cm: Replace members of sa_path_rec with 'struct sgid_attr *'

While processing a path record entry in CM messages the associated GID
attribute is now also supplied.

Currently for RoCE a netdevice's net namespace pointer and ifindex are
stored in path record entry. Both of these fields of the netdev can change
anytime while processing CM messages. Additionally storing net namespace
without holding reference will lead to use-after-free crash. Therefore it
is removed. Netdevice information for RoCE is instead provided via
referenced gid attribute in ib_cm requests.

Such a design leads to a situation where the kernel can crash when the net
pointer becomes invalid. However today it is always initialized to
init_net, which cannot become invalid. In order to support processing
packets in any arbitrary namespace of the received packet, it is necessary
to avoid such conditions.

This patch removes the dependency on the net pointer and ifindex; instead
it will rely on SGID attribute which contains a pointer to netdev.

Signed-off-by: Parav Pandit <parav@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
drivers/infiniband/core/cm.c
drivers/infiniband/core/cma.c
drivers/infiniband/core/sa_query.c
drivers/infiniband/core/uverbs_marshall.c
drivers/infiniband/ulp/ipoib/ipoib_main.c
include/rdma/ib_sa.h