]> git.baikalelectronics.ru Git - kernel.git/commit
mailbox: skip complete wait event if timer expired
authorSudeep Holla <sudeep.holla@arm.com>
Tue, 21 Mar 2017 11:30:15 +0000 (11:30 +0000)
committerJassi Brar <jaswinder.singh@linaro.org>
Thu, 27 Apr 2017 10:50:04 +0000 (16:20 +0530)
commit0c36d397aa891e3adb9c704d2091b9dce1e1902d
tree802adbab75077e90751f4c59ecf8ffaabc4c2737
parentcc975a9b48d6f11779a64acc75906548ff5a9a62
mailbox: skip complete wait event if timer expired

If a wait_for_completion_timeout() call returns due to a timeout,
complete() can get called after returning from the wait which is
incorrect and can cause subsequent transmissions on a channel to fail.
Since the wait_for_completion_timeout() sees the completion variable
is non-zero caused by the erroneous/spurious complete() call, and
it immediately returns without waiting for the time as expected by the
client.

This patch fixes the issue by skipping complete() call for the timer
expiry.

Fixes: 0d498d541546 ("mailbox: Introduce framework for mailbox")
Reported-by: Alexey Klimov <alexey.klimov@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/mailbox.c