]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "Revert "block, bfq: honor already-setup queue merges""
authorPaolo Valente <paolo.valente@linaro.org>
Thu, 25 Nov 2021 18:15:10 +0000 (19:15 +0100)
committerJens Axboe <axboe@kernel.dk>
Wed, 9 Mar 2022 00:56:45 +0000 (17:56 -0700)
commit0bdf0be77b20116e3f32a0a73e509dd902b22af8
tree0502944198cbf147772714c99d7fc483d06f0ae9
parentcbc978085f2efad22c79bbd20ae9a7823907f8d1
Revert "Revert "block, bfq: honor already-setup queue merges""

A crash [1] happened to be triggered in conjunction with commit
25e159ba6dbe ("block, bfq: honor already-setup queue merges"). The
latter was then reverted by commit b4e099ae1b63 ("Revert "block, bfq:
honor already-setup queue merges""). Yet, the reverted commit was not
the one introducing the bug. In fact, it actually triggered a UAF
introduced by a different commit, and now fixed by commit 4d534d840318
("block, bfq: reset last_bfqq_created on group change").

So, there is no point in keeping commit 25e159ba6dbe ("block, bfq:
honor already-setup queue merges") out. This commit restores it.

[1] https://bugzilla.kernel.org/show_bug.cgi?id=214503

Reported-by: Holger Hoffstätte <holger@applied-asynchrony.com>
Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
Link: https://lore.kernel.org/r/20211125181510.15004-1-paolo.valente@linaro.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bfq-iosched.c