]> git.baikalelectronics.ru Git - kernel.git/commit
rtnetlink: fix userspace API breakage for iproute2 < v3.9.0
authorMichal Schmidt <mschmidt@redhat.com>
Wed, 28 May 2014 12:15:19 +0000 (14:15 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 12 Jun 2014 18:07:42 +0000 (11:07 -0700)
commit0b8bb2e51b530430fab7e851f9739f531ef5015c
tree50c7e303026871c65ffbfd8480a8aa20524cee98
parent9ae5003419bc03e2c87d82d6e0b21c9f5f723651
rtnetlink: fix userspace API breakage for iproute2 < v3.9.0

When running RHEL6 userspace on a current upstream kernel, "ip link"
fails to show VF information.

The reason is a kernel<->userspace API change introduced by commit
4d73c6f43038f ("rtnetlink: Call nlmsg_parse() with correct header length"),
after which the kernel does not see iproute2's IFLA_EXT_MASK attribute
in the netlink request.

iproute2 adjusted for the API change in its commit 63338dca4513
("libnetlink: Use ifinfomsg instead of rtgenmsg in rtnl_wilddump_req_filter").

The problem has been noticed before:
http://marc.info/?l=linux-netdev&m=136692296022182&w=2
(Subject: Re: getting VF link info seems to be broken in 3.9-rc8)

We can do better than tell those with old userspace to upgrade. We can
recognize the old iproute2 in the kernel by checking the netlink message
length. Even when including the IFLA_EXT_MASK attribute, its netlink
message is shorter than struct ifinfomsg.

With this patch "ip link" shows VF information in both old and new
iproute2 versions.

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/rtnetlink.c