]> git.baikalelectronics.ru Git - kernel.git/commit
arm: remove "optimized" SHA1 routines
authorLinus Torvalds <torvalds@linux-foundation.org>
Sun, 7 Aug 2011 21:07:03 +0000 (14:07 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 7 Aug 2011 21:07:03 +0000 (14:07 -0700)
commit0ad52f4ff1c32332cc9935654e745e778be562e3
tree1f1fa8d67a9f36980e457b77234d89f6761098c9
parent86e4d2ca222376091628b917d93ac293e205c246
arm: remove "optimized" SHA1 routines

Since commit 8febfc1b0e57 ("lib/sha1: use the git implementation of
SHA-1"), the ARM SHA1 routines no longer work.  The reason? They
depended on the larger 320-byte workspace, and now the sha1 workspace is
just 16 words (64 bytes).  So the assembly version would overwrite the
stack randomly.

The optimized asm version is also probably slower than the new improved
C version, so there's no reason to keep it around.  At least that was
the case in git, where what appears to be the same assembly language
version was removed two years ago because the optimized C BLK_SHA1 code
was faster.

Reported-and-tested-by: Joachim Eastwood <manabian@gmail.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>
Cc: Nicolas Pitre <nico@fluxnic.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/arm/lib/Makefile
arch/arm/lib/sha1.S [deleted file]