]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/execlists: Apply a full mb before execution for Braswell
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 6 Dec 2018 08:44:31 +0000 (08:44 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Thu, 6 Dec 2018 21:12:30 +0000 (21:12 +0000)
commit0ad3141e041dfccdb0c4f9fb4aba97be48692b94
treef870c0ef4565072da1c43a5cebd55612340074ee
parent0ecb45247c2915c3c21693dd2881f6e1f1e803f2
drm/i915/execlists: Apply a full mb before execution for Braswell

Braswell is really picky about having our writes posted to memory before
we execute or else the GPU may see stale values. A wmb() is insufficient
as it only ensures the writes are visible to other cores, we need a full
mb() to ensure the writes are in memory and visible to the GPU.

The most frequent failure in flushing before execution is that we see
stale PTE values and execute the wrong pages.

References: 152cd5a418b4 ("drm/i915/execlists: Force write serialisation into context image vs execution")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: stable@vger.kernel.org
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181206084431.9805-3-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/intel_lrc.c