]> git.baikalelectronics.ru Git - kernel.git/commit
s390/qeth: fix error handling for isolation mode cmds
authorJulian Wiedmann <jwi@linux.ibm.com>
Wed, 17 Jun 2020 14:54:52 +0000 (16:54 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Jun 2020 03:27:42 +0000 (20:27 -0700)
commit0aa1ee61dd47a40df5c1145e19dc43658cb8cdf4
tree9775f9d9f5f2fec7cb84e6a998ce2491b49a1465
parentcde76bafdbfc35fa68b00d17f2c1c8295552dee6
s390/qeth: fix error handling for isolation mode cmds

Current(?) OSA devices also store their cmd-specific return codes for
SET_ACCESS_CONTROL cmds into the top-level cmd->hdr.return_code.
So once we added stricter checking for the top-level field a while ago,
none of the error logic that rolls back the user's configuration to its
old state is applied any longer.

For this specific cmd, go back to the old model where we peek into the
cmd structure even though the top-level field indicated an error.

Fixes: 95f082cf0dea ("s390/qeth: fix error handling in adapter command callbacks")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_core_main.c