]> git.baikalelectronics.ru Git - kernel.git/commit
xfs: use MMAPLOCK around filemap_map_pages()
authorDave Chinner <dchinner@redhat.com>
Tue, 30 Jun 2020 18:28:53 +0000 (11:28 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Mon, 6 Jul 2020 17:46:58 +0000 (10:46 -0700)
commit0a9f73cddafb39dd36e4ce5b44a943aacfde126d
treeb87f7631b707b36fa06e695c119fc3f9dcdd16c3
parentc5c889139df8075faf25c0fb952c6c93f932e310
xfs: use MMAPLOCK around filemap_map_pages()

The page faultround path ->map_pages is implemented in XFS via
filemap_map_pages(). This function checks that pages found in page
cache lookups have not raced with truncate based invalidation by
checking page->mapping is correct and page->index is within EOF.

However, we've known for a long time that this is not sufficient to
protect against races with invalidations done by operations that do
not change EOF. e.g. hole punching and other fallocate() based
direct extent manipulations. The way we protect against these
races is we wrap the page fault operations in a XFS_MMAPLOCK_SHARED
lock so they serialise against fallocate and truncate before calling
into the filemap function that processes the fault.

Do the same for XFS's ->map_pages implementation to close this
potential data corruption issue.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/xfs_file.c