]> git.baikalelectronics.ru Git - kernel.git/commit
firmware: qcom_scm: fix bogous abuse of dma-direct internals
authorChristoph Hellwig <hch@lst.de>
Tue, 14 Apr 2020 12:31:36 +0000 (14:31 +0200)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Tue, 21 Apr 2020 06:20:00 +0000 (23:20 -0700)
commit0a9b103527280d9341c68e44dfe68456e9a86496
tree7fa3de01c386bbdf89fa9f88a586758be0fe7109
parent9ce9a27b5a94efe10b53ebe72d6462723923012f
firmware: qcom_scm: fix bogous abuse of dma-direct internals

As far as the device is concerned the dma address is the physical
address.  There is no need to convert it to a physical address,
especially not using dma-direct internals that are not available
to drivers and which will interact badly with IOMMUs.  Last but not
least the commit introducing it claimed to just fix a type issue,
but actually changed behavior.

Fixes: 8f70bc36ceb86 ("firmware: qcom_scm: Use proper types for dma mappings")
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20200414123136.441454-1-hch@lst.de
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/firmware/qcom_scm.c