]> git.baikalelectronics.ru Git - kernel.git/commit
projects / kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: f4412c3) | patch
drivers/ata/pata_pcmcia.c: adjust suspicious bit operation
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 6 Jun 2012 21:41:40 +0000 (23:41 +0200)
committerJeff Garzik <jgarzik@redhat.com>
Wed, 25 Jul 2012 19:06:20 +0000 (15:06 -0400)
commit0a80178bcc810e2d2c1951553edfdaad06dd98cc
tree9a4f5fcfe3531db8585d9d1b822f79e38574b370tree | snapshot
parentf4412c32568f7a71aac53fcf4f1f067e563a8381commit | diff
drivers/ata/pata_pcmcia.c: adjust suspicious bit operation

IO_DATA_PATH_WIDTH_8 is 0, so a bit-and with it is always false.  The
value IO_DATA_PATH_WIDTH covers the bits of the IO_DATA_PATH constants, so
first pick those bits and then make the test using !=.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/pata_pcmcia.c diff | blob | history
Linux Kernel Source Tree.