]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: dt-bindings: ufs: Fix the compatible string definition
authorDouglas Anderson <dianders@chromium.org>
Fri, 12 Oct 2018 21:39:26 +0000 (14:39 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 8 Feb 2019 22:40:03 +0000 (17:40 -0500)
commit0a708d27c0cdb67b94191d78093acd9e114109fb
treebcc8968fcb33b450cf1689bf164c5c44c6dcb1a9
parent81fd7578aec358417173b11eeb71d220bc02e929
scsi: dt-bindings: ufs: Fix the compatible string definition

If you look at the bindings for the UFS Host Controller it says:

- compatible: must contain "jedec,ufs-1.1" or "jedec,ufs-2.0", may
              also list one or more of the following:
                 "qcom,msm8994-ufshc"
                 "qcom,msm8996-ufshc"
                 "qcom,ufshc"

My reading of that is that it's fine to just have either of these:
1. "qcom,msm8996-ufshc", "jedec,ufs-2.0"
2. "qcom,ufshc", "jedec,ufs-2.0"

As far as I can tell neither of the above is actually a good idea.

For #1 it turns out that the driver currently only keys off the
compatible string "qcom,ufshc" so it won't actually probe.

For #2 the driver won't probe but it's not a good idea to keep the SoC
name out of the compatible string.

Let's update the compatible string to make it really explicit.  We'll
include a nod to the existing driver and the old binding and say that
we should always include the "qcom,ufshc" string in addition to the
SoC compatible string.

While we're at it we'll also include another example SoC known to have
UFS: sdm845.

Fixes: ac1bd9cff3ed ("scsi: ufs: make the UFS variant a platform device")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt